Closed Cybermaxke closed 7 years ago
@Meronat You can checkout the available recipes in the registry modules:
@Cybermaxke As I am looking through this right now and testing it out, I noticed shift clicking a stack of fuel(in this case coal) into the furnace places the stack into both input slots of the furnace client side. The actual stack ends up in the top slot while the ghost item stack is in the bottom slot and disappears once you move it.
There is also weird behavior if both slots have the fuel in it, but it's hard to explain.
Part of the problem possibly can be solved by prioritizing the bottom slot if it is fuel, but some of the issues will still remain.
Edit: There is also weird behavior shift-clicking other items in general actually, causing lots of ghost stacks in the inventory.
Edit: Oops I see you mentioned this already, here is some more information I guess.
A note for later implementation(in this PR works too) - Crafting benches don't drop their items yet
@Meronat I might fix the ghost stacks for now in the furnace, but implement the proper behavior later with the refactor. As for the crafting benches drops, I could already implement that in this PR.
@Meronat The test plugin is a good idea, I will try to finish the PR tomorrow and merge it then.
Todo list:
The changes look good to me and work appropriately :)
Features:
Ingredient
(IIngredient
).2x iron_ingot -> steel_ingot
Not included (due the size of the PR):