Open tabacitu opened 4 years ago
Not that productive comment, but maybe it's in the right direction ? I'm using the package in my current project.
I saw this feature Request and put a small amount of work (only in the project for now). I manage to use only basic bootstraps, 1 line in style="" :$ to put negative margin.
I love that @mamarmite - I would much rather do it using Bootstrap alone than tying ourselves to a new dependency. If you can submit a PR I will gladly take a look and merge - seems like a non-breaking change.
@mamarmite any chance you can copy-paste your view code here? We'll soon be giving this repo some much-needed love, and if we have you interface code we might just add it for everyone.
Thanks!
Hi @tabacitu Yess no problem. I push the current state here : https://github.com/mamarmite/backpack-revise-operations-views-refactored-as-timeline/tree/master
I must say that it contains a checkup to avoid adding a revision for the create_at revisions. It's part of the reason why I didn't share this sooner, that must be set cleaner as a config.
I refactored the structure too, like to Dry a bit for me, but this add view rendering. I didn't check the loading speed impact tho.
Feature Request
What's the feature you think this package should have?
Cleaner timeline view, by using https://jablon.me/bootstrap-milestones/
Have you already implemented a prototype solution, for your own project?
No... 👀
Do you see this as a core feature or an add-on?
Part of the Revise operation, definitely. But it'll probably be a breaking change since it needs one additional CSS file.