search

LaravelDaily / laravel-invoices

Laravel package to generate PDF invoices from various customizable parameters
GNU General Public License v3.0
1.4k stars 304 forks source link

currencyCode() method doesn't work #108

Closed atanaspuskulev closed 3 years ago

atanaspuskulev commented 3 years ago

$invoice->currencyCode(code) PDF generated doesn't honor the currency code passed by currencyCode() method. Instead - the default from config is used.

The other issue is, if you change the currency code in invoices.php (config file) for example in cyrillic - doesn't work. Most probably a font issue.

To Reproduce Steps to reproduce the behavior:

  1. Go to your invoice package homepage 'https://github.com/LaravelDaily/laravel-invoices'
  2. Use your long example (second one).
  3. Try change the currency code.
  4. No error displayed. No matter what currency code you pass - the generated in the pdf is always EUR.

Expected behavior Honor the currency code passed by the method. Omit currency symbol by method passing null (not every currency has symbol).

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.