search

LaravelDaily / laravel-invoices

Laravel package to generate PDF invoices from various customizable parameters
GNU General Public License v3.0
1.4k stars 304 forks source link

Extend customData() method to accept array instead of string #134 #135

Closed denvit closed 2 years ago

denvit commented 2 years ago

This solving Issue #134

mc0de commented 2 years ago

I think this is really not necessary, also breaking change if other users already use this function. And added new dependency?

Have to close that, and please continue on issue thread https://github.com/LaravelDaily/laravel-invoices/issues/134

mc0de commented 2 years ago

On other hand you can just extend a class and wrap/override methods in any way you want for your case.

denvit commented 2 years ago

@mc0de Yeah, you're right. Let's leave it as it is.