search

LaravelDaily / laravel-invoices

Laravel package to generate PDF invoices from various customizable parameters
GNU General Public License v3.0
1.39k stars 303 forks source link

Manage lang path for Laravel >= 9 #179

Closed s-damian closed 1 year ago

s-damian commented 1 year ago

InvoiceServiceProvider: Manage lang path for Laravel >= 9

mc0de commented 1 year ago

hi, does this fix any particular issue?

s-damian commented 1 year ago

It doesn't fix a bug. But this is to make it consistent with Laravel's lang architecture >= 9

mc0de commented 1 year ago

this will be reviewed with next release if doesn't have any side effects

nathan-io commented 1 year ago

@mc0de this PR is definitely needed.

When I installed this package in a project and published its assets, all of our lang references broke. Some views even start throwing array to string exceptions.

This is a Laravel 9 project where we had translation files within /lang.

When I removed the resources/lang folder, the issue was resolved. I found the tip at https://stackoverflow.com/a/71085860

I also submitted a PR for this, as I didn't see this one.

Jacobtims commented 1 year ago

This is a serious problem...

mc0de commented 1 year ago

Thank you for PR