LaravelDaily / laravel-invoices

Laravel package to generate PDF invoices from various customizable parameters
GNU General Public License v3.0
1.39k stars 303 forks source link

path to translations is incorrect #209

Closed Treggats closed 10 months ago

Treggats commented 11 months ago

Describe the bug Due to a non-existent path, the translations are no longer loaded.

To Reproduce Steps to reproduce the behaviour:

use the following in a test, this will currently fail.

self::assertSame('Prijs', __('invoices::invoice.price', locale: 'nl_NL'));

Expected behavior The Dutch (and other languages) should be loaded.

Change which will fix the issue https://github.com/LaravelDaily/laravel-invoices/blob/master/src/InvoiceServiceProvider.php#L31

-$this->loadTranslationsFrom(__DIR__ . '/../resources/lang', 'invoices');
+$this->loadTranslationsFrom(__DIR__ . '/../lang', 'invoices');
mc0de commented 10 months ago

This is fixed with the new release.