Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] 4.0 System Exhaustion Effects not working #109

Closed ctbritt closed 2 months ago

ctbritt commented 2 months ago

Describe the bug When applying exhaustion on the char sheet in 2024 D&D 4.0.2 while Custom D&D 5e is enabled, there is no exhaustion penalty applied.

Module Data Custom DND5E.json

Steps to reproduce

  1. Enable Custom D&D 5e module
  2. Open Char sheet and apply exhaustion via the pips
  3. Make a D20 check.
  4. See error

Versions:

Additional context With Custom 5e enabled (with 3 levels of exhaustion): CleanShot 2024-09-19 at 18 32 46

With Custom 5e disabled (with 3 levels of exhaustion): CleanShot 2024-09-19 at 18 35 38

This happens even when Custom 5e is the only module enabled.

Larkinabout commented 2 months ago

Thanks, I'd missed the new reduction properties. I usually merge in the core config in case there's any new additions, but I hadn't done it for conditions. I've also added the properties to the Exhaustion condition item in Configure Conditions, so you can change them as desired.

Fixed in 1.0.4.

image

matikheit commented 2 months ago

Describe the bug Using Custom D&D 5e it happened to me that when I added our weapon properties to the system, then it did not allow me to edit any object that was considered a weapon. I could edit backgrounds, classes and even trinkets, but when I try to open a weapon, I don't get the screen to read its description or edit it. When I deactivate the module, then I can open it.

Versions:

Larkinabout commented 2 months ago

This is a different issue. Please create a new issue and make sure to include your debug file from Custom D&D 5e.

matikheit commented 2 months ago

I just don't know how to do it, because I don't know what a debug file is :(

Larkinabout commented 2 months ago

Create a new Bug issue and it will tell you how to get the file. It's the Module Data part of the issue.