search

LarsHeppert / opentestbed

Automatically exported from code.google.com/p/opentestbed
0 stars 0 forks source link

PublicGameInfo and PublicPlayerInfo self-updating #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
As it stands right now PublicGameInfo and PublicPlayerInfo do not have
public methods to update private variables.

I propose that PublicGameInfo has a public method: update(Action act,
double param, int seat) which will update the GameInfo (checking to make
sure the action was valid for the given seat). 

PublicPlayerInfo will similarly have a method: update(Action act, double
param) which will be called by the PublicGameInfo to update each player
when it acts.

Original issue reported on code.google.com by schatzbe...@gmail.com on 16 Mar 2010 at 11:13

GoogleCodeExporter commented 8 years ago 
I'll start on this, speak now if you don't think its the right way to do it.

Original comment by schatzbe...@gmail.com on 16 Mar 2010 at 11:50

GoogleCodeExporter commented 8 years ago 
Don't know if its the right way :) But as a friend of refactoring and agile we 
can
change it later, if it doesn't fit or when we find a better way.

Original comment by bluegasp...@gmail.com on 17 Mar 2010 at 12:25

GoogleCodeExporter commented 8 years ago 
Started on this

Original comment by schatzbe...@gmail.com on 17 Mar 2010 at 7:22

GoogleCodeExporter commented 8 years ago 
Dan, I think you don't need the double-param in both update-methods of GameInfo 
and
Players.
The action-objects hold the amounts themselfes (for a raise splitted into call 
and
raise amount).

Original comment by bluegasp...@gmail.com on 21 Mar 2010 at 8:01

GoogleCodeExporter commented 8 years ago 
Yeah, you're right, that will need to be fixed.

Original comment by schatzbe...@gmail.com on 21 Mar 2010 at 4:40

GoogleCodeExporter commented 8 years ago 
Blue (or anyone for that matter), if you feel like it go ahead and finish this. 
I've
pushed what I have and work is really heavy now so I can't afford time. If you 
feel
its holding you back and want to do it, by all means do so.

Original comment by schatzbe...@gmail.com on 26 Mar 2010 at 1:13

GoogleCodeExporter commented 8 years ago 
I started with implementing Showdowns and WinEvents. Not ready to commit though.

Original comment by bluegasp...@gmail.com on 27 Mar 2010 at 12:37

GoogleCodeExporter commented 8 years ago 
GameInfo now handles showdown - I'll close this issue and rather create more
finegrained issues for open stuff in the gameinfo, so that work can be splitted 
better

Original comment by bluegasp...@gmail.com on 27 Mar 2010 at 11:51