search

LaserWeb / LaserWeb4

Collaborative effort on the next version of LaserWeb / CNCWeb
GNU Affero General Public License v3.0
713 stars 192 forks source link

REQUEST: more detailed errors description in svg loading #498

Closed lucalcin closed 6 years ago

lucalcin commented 6 years ago

Hi,

loading svg files, I often got errors like "the file has minor issues…" or "the file has serious issues…" These errors are unuseful, better if the error were more verbose, at least reporting a line number for error checking.

Because errors happens easily in very large files, a such feature can save a lot of time in fixing files.

Thanks

Luke

jorgerobles commented 6 years ago

Sorry, there are no plans of improving SVG loading for now as far as I know. Please use https://github.com/lautr3k/lw.svg-parser for svg issues.

lucalcin commented 6 years ago

Sorry, laserweb reports with serious issues the same file that lw.svh-parser loads without problems. Is it a Laserweb problem? Can I send to you privately a sample of my files?

jorgerobles commented 6 years ago

LaserWeb needed to make some tweaks to properly display the files on the gl workspace. You can attach the files here for inspection.

lucalcin commented 6 years ago

Sorry, are private files, I cannot attach them in a public site. Please let me know how send them for testing in a private way

lucalcin commented 6 years ago

"LaserWeb needed to make some tweaks" Are these tweaks documented somewhere?

jorgerobles commented 6 years ago

Er, nope. the tweaks are internal code for the GL, and viewbox transforms. If you have some coding experience just compare the bundled version of lw.svg-parser with the original fork.

lucalcin commented 6 years ago

I wish to have enough coding experience to helping in develop LW4, but unfortunately I haven't… :(

What about the private sending of the files?