Laura10101 / contractor-tax-calculator

0 stars 2 forks source link

Multiple Jest views tests for the config app are timing out #217

Closed Laura10101 closed 10 months ago

Laura10101 commented 10 months ago

The following tests are timing out:

● Status views › Success views › Successfully saving › Questions › should display a success message, clear the app state, and refresh the appropriate display components ● Status views › Success views › Successfully saving › Multiple choice options › should display a success message, move the parent state to the app state, and refresh the appropriate display components ● Status views › Success views › Successfully saving › Rulesets › should display a success message, clear the app state, and refresh the appropriate display components ● Status views › Success views › Successfully saving › Rules › should display a success message, clear the app state, and refresh the appropriate display components ● Status views › Success views › Successfully saving › Rule tiers › should display a success message, clear the app state, and refresh the appropriate display components ● Status views › Success views › Successfully saving › Rule tiers › should display a success message, clear the app state, and refresh the appropriate display components ● Question views › Deleting questions › Confirming deletion › should hide confirmation dialog and trigger DELETE request ● Multilple choice option views › Creating multiple choice options › should hide the create option dialog and generate an appropriate request for an option ● Multilple choice option views › Deleting multiple choice options › Confirming deletion › should hide confirmation dialog and trigger DELETE request ● Ruleset views › Creating rulesets › should hide the create ruleset dialog and generate an appropriate request for a ruleset ● Ruleset views › Deleting rulesets › Confirming deletion › should hide confirmation dialog and trigger DELETE request ● Ruleset views › Deleting rulesets › Successful deletion › should show a success message, resequence ordinals, clear the app state, and refresh the rulesets display ● Rule views views › Deleting rules › Confirming deletion › should hide confirmation dialog and trigger DELETE request ● Rule views views › Deleting rules › Successful deletion › of a flat rate rule › should show a success message, resequence ordinals, clear the app state, and refresh the rules display ● Rule views views › Deleting rules › Successful deletion › of a tiered rate rule › should show a success message, resequence ordinals, clear the app state, and refresh the rules display ● Rule views views › Deleting rules › Successful deletion › of a secondary tiered rate rule › should show a success message, resequence ordinals, clear the app state, and refresh the rules display ● Rule tier views views › Deleting rule tiers › Successful deletion › of a rule tier › should show a success message, resequence ordinals, clear the app state, and refresh the tiers display ● Rule tier views views › Deleting rule tiers › Successful deletion › of a rule tier › should show a success message, resequence ordinals, clear the app state, and refresh the tiers display ● Rule tier views views › Deleting rule tiers › Successful deletion › of a secondary rule tier › should show a success message, resequence ordinals, clear the app state, and refresh the tiers display ● Rule tier views views › Deleting rule tiers › Successful deletion › of a secondary rule tier › should show a success message, resequence ordinals, clear the app state, and refresh the tiers display

Laura10101 commented 10 months ago

In order to make views testable, parameters were added to allow refresher, creator and updater methods to be passed in as parameters. However, for views which handle AJAX requests, the standard AJAX response parameters had not been declared in all cases meaning that the views did not correctly receive the callback functions when accessing the config app through the browser. The standard AJAX parameters were then added, but this caused the above tests to fail as they were not passing the additional parameters in. Updated the tests to pass in all parameters.