Lauriethefish / ModsBeforeFriday

Beat Saber Mods Before Friday
GNU Affero General Public License v3.0
42 stars 8 forks source link

Add initial implementation of the file dropper #5

Closed FrozenAlex closed 5 days ago

FrozenAlex commented 2 months ago

I ran prettier on it and it added too many formatting changes. Not the prettiest code out there but does the job

WombleWoo7547 commented 1 month ago

lgtm

Lauriethefish commented 6 days ago

Mostly looking good although is there a reason why the mod importing logic in ModManager is reimplemented in DeviceModder? Ideally DeviceModder shouldn't involve mod installing and should just be installation management.

Lauriethefish commented 6 days ago

Mod importing logic now moved to ModManager. Needs a mod import queue to avoid race conditions where two separate drag-drops could cause two separate agent requests to be made simultaneously, which it will not handle gracefully. (it will likely handle it by shitting the bed)

Lauriethefish commented 5 days ago

Now lgtm