search

LeNelSoN / you-are-the-hero

L'API dont vous êtes le héros is an interactive Java API that brings the adventure of "choose your own adventure" stories to life. Users can embark on unique journeys, make decisions at each step, and create dynamic narratives, all while experiencing the nostalgia of classic adventure books.
GNU General Public License v3.0
2 stars 10 forks source link

Fix Issue: 24-Implementation of @ControllerAdvice for Exception Handling #49

Closed RamprasadRajasegar closed 1 month ago

RamprasadRajasegar commented 1 month ago

Implemented GlobalExceptionHandler and removed try-catch blocks wherever applicable. Written test cases using Junit, Mockito

LeNelSoN commented 1 month ago

Hi @RamprasadRajasegar ,

Thank you for your work on the issue regarding exception handling! The code you’ve added to manage the specific exceptions in the application looks great and aligns with what I was expecting.

However, I’d like you to also consider handling generic exceptions that might be thrown by Spring more broadly. For example, in addition to the application-specific exceptions, it would be beneficial to manage exceptions like RuntimeException to prevent unexpected behaviors and ensure that any error is properly captured and handled.

The idea would be to add global error handling in our handler so we can return a consistent message to the user, regardless of the error that occurs. This will help us build a more robust API and improve the overall user experience.

Thanks again for your contribution!

LeNelSoN commented 1 month ago

Hi @RamprasadRajasegar ,

Since I haven't heard back from you regarding the recent PR, I’ll go ahead and merge it as-is to keep the project moving forward. I'll also open a new issue and close #24 to handle general error management, so we can address any remaining points there.

Thank you again for your work on this, and feel free to jump in on the new issue if you'd like!

RamprasadRajasegar commented 1 month ago

Hey @LeNelSoN ,

Sorry, I was busy with my work, so I couldn't check GitHub for a while. Thank you so much for your suggestions.