search

LeaVerou / multirange

A tiny polyfill for HTML5 multi-handle sliders
http://projects.verou.me/multirange/
MIT License
607 stars 82 forks source link

Added a package.json to support install via npm #13

Closed allbinmani closed 7 years ago

dy commented 8 years ago

module.exports = multirange; would be also really appreciated!

allbinmani commented 8 years ago

I think this branch is ready for merge now?

LeaVerou commented 8 years ago

Thanks for contributing! I was traveling so I'm a bit behind on Github. I would love to merge the package.json, but there are also some indentation changes that need to be reverted or justified.

LeaVerou commented 8 years ago

Also we don't use JSHint on this project. If I get a minute, I'll add an ESLint config file.

rasben commented 7 years ago

So.. what ever happened to this one? @LeaVerou

LeaVerou commented 7 years ago

@rasben nobody fixed the indentation issues I mentioned, that's what happened.

allbinmani commented 7 years ago

@LeaVerou Could you please specify further what you refer to with "some indentation changes"? Checked the patch and not sure what you mean. Thanks!

LeaVerou commented 7 years ago

Spaces have been used for indentation.

rasben commented 7 years ago

This has been merged in https://github.com/LeaVerou/multirange/pull/26 and can be closed @allbinmani

allbinmani commented 7 years ago

It's been a year and a half since I used multirange in a project. That project is live, and afaik working as intended. However, it was most likely built using webpack or browserify, and did not include multirange 'directly' in a page.