search

League-of-Foundry-Developers / foundryvtt-devMode

A module with some tools to help enable Foundry VTT package developers.
MIT License
12 stars 15 forks source link

Actor CRUD test unnecessarily includes database operations in it #38

Open mkahvi opened 2 years ago

mkahvi commented 2 years ago

Currently the actor CRUD test creates database backed actors. This adds unnecessary variance in the statistics via database and network transmission latencies.

It should instead create synthetic actor with Actor.create(data, {temporary:true}) so it measures only the actual processing time instead of also network and server latency.

akrigline commented 2 years ago

The Network and Server latency are useful indications of server health in some cases. They were interesting metrics when we first started exploring this concept.

It might be worth making an additional temporary test, but I would not remove the existing full blown test.

mkahvi commented 2 years ago

It might be worth making an additional temporary test, but I would not remove the existing full blown test.

Way ahead of you, I think xD

akrigline commented 2 years ago

that you are! big thanks!

mkahvi commented 2 years ago

Alright, the PR was a bust due to upstream limitations: https://gitlab.com/foundrynet/foundryvtt/-/issues/6824