search

LedgerHQ / app-openpgp

OpenPGP Card Application
Apache License 2.0
123 stars 21 forks source link

Update cv25519 decrypt function #103

Closed cedelavergne-ledger closed 5 months ago

cedelavergne-ledger commented 8 months ago

1st step to fix cv25519 decryption. Now the code doesn't return CX_INVALID_CURVE anymore.

Remaining an issue show on the PC side:

gpg: public key is 551E384EA3608B44
gpg: no running gpg-agent - starting '/usr/bin/gpg-agent'
gpg: waiting for the agent to come up ... (5s)
gpg: connection to agent established
gpg: using subkey 551E384EA3608B44 instead of primary key BA8BF32C7557C015
gpg: pinentry launched (46842 gnome3 1.1.1 /dev/pts/2 xterm-256color :0 20620/1000/5 1000/1000 -)
gpg: ecdh failed in gcry_cipher_decrypt: Checksum error
gpg: using subkey 551E384EA3608B44 instead of primary key BA8BF32C7557C015
gpg: encrypted with 255-bit ECDH key, ID 551E384EA3608B44, created 2024-03-15
      "testkey"
gpg: public key decryption failed: Checksum error
gpg: decryption failed: No secret key
Decryption error!

Checklist

ledger-wiz-cspm-secret-detection[bot] commented 8 months ago

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.01%. Comparing base (400ff19) to head (db129e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #103 +/- ## ======================================== Coverage 27.01% 27.01% ======================================== Files 1 1 Lines 211 211 ======================================== Hits 57 57 Misses 154 154 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-openpgp/pull/103/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-openpgp/pull/103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `27.01% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.