search

LedgerHQ / app-openpgp

OpenPGP Card Application
Apache License 2.0
123 stars 21 forks source link

ledger nano x compatibility #46

Closed mhhf closed 8 months ago

mhhf commented 5 years ago

I'm a heavy user of this app with my nano s and was wondering if and when it will appear for my ledger x.

fubuloubu commented 5 years ago

This was actually the main reason I bought the X, what's involved in getting the X to be compatible?

cslashm commented 5 years ago

I had to port the UI. I was just a bit buzy this last days, sorry . But I'm on the deck and will work on very very soon. I also use it every day and need it :p

jonathancross commented 5 years ago

@cslashm Any updates for us here?

aitorpazos commented 4 years ago

I was testing this on my ledger nano X and it reboots when asked to generate the keys (Using https://salsa.debian.org/rousseau/CCID from master as it contains the addition to support it in libccid)

aitorpazos commented 4 years ago

Further testing resulted in ECC Curve 25519 keys being generated correctly :) . I suspect the issue may be related to the fact that I was using RSA 4096 in my first tests and the key sizes may become too big for the app (RSA 2048 worked fine as well).

cslashm commented 4 years ago

I think the time to generated 4096 is too long and the host ccid trigger a timeout

jonathancross commented 4 years ago

@cslashm Are you still working on Nano X support or should it be considered complete (at least for Curve25519)?

cslashm commented 4 years ago

The deployed version is the one I use day to day. (and with cv/ed-25519)) Dont forget to backup/resetore with provided pythontool.

jonathancross commented 4 years ago

Thanks for the reply.

backup/resetore with provided pythontool.

So the seed backup isn't enough to restore pgp keys?

cslashm commented 4 years ago

@jonathancross yes it is