chabroA commented 2 years ago

🦒 Context (issues, jira)

💻 Description / Demo (image or video)

🔗 https://github.com/LedgerHQ/ledger-live-common/pull/1927

Add FTX as swap provider
Add Login, KYC and MFA widgets to swap flow
Add change provider option to change rate / provider
Update settings to allow reset third party data (and thus clean partner login / KYC data stored locally)

📸 Screenshot of updated parts bellow 👇

Settings page

![3](https://user-images.githubusercontent.com/9203826/156803834-ce206ee7-d1f0-49f9-96f9-6a9b4e766969.png) ![3](https://user-images.githubusercontent.com/9203826/156803861-02b8d8ee-e4f3-4894-864b-edd0ad95c0be.png) ![3 1](https://user-images.githubusercontent.com/9203826/156803876-e6f2bd3e-0636-4f44-94df-8d94c3619afc.png) ![3 1](https://user-images.githubusercontent.com/9203826/156803889-757bbbdf-8d5f-447d-8a6b-aa1fe3c543a5.png)

Swap page

### Before: ![1](https://user-images.githubusercontent.com/9203826/156804107-0e60c525-471c-4bab-a21b-4c176b57140e.png) ![2](https://user-images.githubusercontent.com/9203826/156804110-23f06465-8b66-4144-a6f8-1bbf7452b7e4.png) ### After:

New widgets

![Screenshot 2022-03-04 at 17 15 15](https://user-images.githubusercontent.com/9203826/156804376-3697690e-03a8-4220-b9b5-ec1ea39a5586.png) ![Screenshot 2022-03-04 at 17 15 47](https://user-images.githubusercontent.com/9203826/156804388-0144fad2-4b9d-4fbc-9773-0172fcbc1c28.png)

🧪 QA steps:

To put it shortly, test the different login / KYC flows for swap with FTX and FTX US. FTX should always be first provider available.

You can use these test credentials in order to test each flow. Follow the instruction on the page to use a test account. ⚠️ Do not try to update KYC (i.e: submit the form) or enable MFA on any of these test accounts ⚠️

Use provider 7 to get the compatible nano apps

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

on QA: at least one of these two checkboxes must be checked:
- [x] a specific test planned is defined on Jira
- [ ] this PR is covered by automatic UI test
on delivery: at least one of these two checkboxes must be checked:
- [ ] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
- [ ] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

☑️ TODO before merge / release

[ ] update LLC dep
[ ] remove SWAP_API_BASE env override (once swap api is in prod)
[ ] deploy nano apps from provider 7 to prod

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be groomed for next release, you need to:

[ ] pass the CI
[ ] if needed, run /generate-screenshots
[ ] have a dev review
[ ] have a QA review

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

github-actions[bot] commented 2 years ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	23.46%	38/162
🔴	Branches	20.51%	8/39
🔴	Functions	3.64%	2/55
🔴	Lines	24.16%	36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 4f19bb24a11ce73c2d510e753365082ed4856b84

LedgerHQ / ledger-live-desktop

[FEATURE] Add FTX to live swap #4959