search

LedgerHQ / ledger-nano-s

Ledger Nano S, a personal security device from Ledger (blockchain / bitcoin / ethereum / FIDO)
Apache License 2.0
278 stars 41 forks source link

Ledger Nano S consistently freezes when signing Stellar transactions #66

Open vcarl opened 4 years ago

vcarl commented 4 years ago

When using the Account Viewer, which is the officially recommended wallet, payments consistently fail to sign and leave the Ledger Nano S in a state requiring it be powercycled.

After updating @ledgerhq/* dependencies from npm and explicitly setting a 1 minute timeout in the Account Viewer, the only way I'm able to confirm a transaction is by waiting 30s with the Ledger Nano S displaying Review Transaction, then progressing through the transaction confirmation flow. Any other attempt to submit a transaction results in the Ledger Nano S freezing on the Finalize Transaction > screen, remaining unresponsive until power is removed. We've also had a Ledger Nano S brick after freezing.

Full workaround steps:

edit: removed workaround steps, because further testing across browsers indicates transactions may succeed effectively at random. See comment

This effectively breaks Ledger hardware wallets for all Stellar users, and has been reported as far back as Jan 14 2020 (and Jan 16th as well).

shammmuk commented 4 years ago

Tried it and does not work still stuck

02ysoe commented 4 years ago

I'm experiencing the exact same problem and after numerous tries, I still haven't been successful with the proposed workaround above. Really frustrating!

Is LedgerHQ looking into fixing this problem?

Anyone else who has been successful with the workaround?

EDIT: Just tried 5 times in a row with the workaround - still no luck. In 2 out of 5 tries, it went through to the below 'transaction failed' message: image

vcarl commented 4 years ago

I did some further testing with 2 different Ledger Nano S devices on various browsers, and the results are pretty confusing. On most browsers I was able to send a payment with enough trial-and-error, but I don't see any patterns as to when the transactions are signed successfully. I'm going to remove the workaround instructions because I think they'll be more confusing than helpful. Testing results:

To be clear, I'm not sure that there's any distinction between these 2 Ledger Nano S devices, I just happen to know that they were purchased at different times. Given that this appears to be a firmware issue, age of the device seemed like a potential factor.

02ysoe commented 4 years ago

A response from LedgerHQ would be appreciated. Still experiencing same problem:(