codecov[bot]
commented
2 years ago Codecov Report
Merging #835 (f153230) into master (f9554d5) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #835 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 82 82
Lines 5004 5004
Branches 890 890
=======================================
Hits 2282 2282
Misses 2526 2526
Partials 196 196 | Impacted Files | Coverage Δ | |
|---|---|---|
| packages/devices/src/index.ts | 0.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f9554d5...f153230. Read the comment docs.
Type
Bugfix
Context
https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/462?modal=detail&selectedIssue=LIVE-1799
The Nano S Plus capacity is 1536 KB and not 1533 KB
What is affected / Test plan
The
memorySizeproperty is used to compute the remaining free storage space in the nano + display to the user in the LLD and LLM (the computation is done in live-common).The new devices package has been tested on LLD:
previous version with 1533 KB
**Look at the "free" storage section on the bottom right** new version with 1536 KB
**Look at the "free" storage section on the bottom right** Note
Also bump to node v14 in the
.nvmrcfile (same as the version used in LLD and LLM)