Closed joepreludian closed 3 years ago
@LeeHanYeong and @michaldyczko Feel free to test those changes into a running example under my Fork;
make test
for performing the tests under testproject
; $ cd testproject;
$ poetry install;
$ poetry run python manage.py migrate;
$ poetry run python manage.py createsuperuser;
$ poetry run python manage.py runserver;
Point your browser to: http://localhost:8000/admin/post/quillmaster/;
There is two types of Inlines: Stacket and Tabbed ones.
Have fun!
Hey @LeeHanYeong Could you explain me why you're still using setup.py rather than working with poetry? I would like to understand better... So I can change my PR in order to be compatible with your code. Thank you!
Hello Friends,
Long story
First of all, thank you for the amazing library. Reading a previous PR #30 I reallized that the project wasn't working well with Inlines. I'm creating a tool that needs to create multiple WYSIWYG inside Inlines. I noticed that @michaldyczko created a different version which supports Inlines.
I cloned his repo and tried to test myself on my brand new Django 3.2. Somehow didn't worked as I expected. So I though to pick his work in progress and try to make it work on latest version of Django. So I did it. Amongst the changes, I did the following changes, as being described below:
pyproject.toml
will be necessary to get this up and running.pyproject.toml
dependencies - The django_quill package will only havedjango
as a dependency. The stuff needed to create docs stills at the developer dependencies.testproject
. I started from scratch a new Django 3.2 project with apost
application. Also I copied all the stuff fromplayground
and tried to keep the codebase clean; Also I created a brand new poetry project inside this testapp with the django-quill-editor dev dependency pointing to up level, so we do not need to polute the project's pyproject.toml. I think it will be better to test without messing with the main project.Makefile
for more info.Strategy to get working the Editor into the Inlines;
Since Django makes use of DOM clonning, it was difficult to enable the quill Editor. So I created a strategy that makes this maneuver possible. Below there is the basic idea:
__prefix__
object as a cloned one;Please feel free to change whatever you guys find necessary. I hope that my change can be useful. Thanks again and have a great weekend!