search

Left-on-Read / leftonread

Left on Read
https://leftonread.me/
Other
166 stars 16 forks source link

🐛: fix check permissions hanging for some users by unpromisifying it #472

Closed alexdanilowicz closed 1 year ago

alexdanilowicz commented 1 year ago

It seems for 35% of users, get started would hang. At first, I thought this was an initialize problem, but Amplitude (and all the support tickets) suggests that actually initialize never starts and the permission check just hangs. Hangs meaning it never resolves.

I actually was able to repro locally by removing full disk for my terminal, and then adding it and restarting the app. It hanged. When I logged, it seemed that the promise never resolved. it just waited and waited. not sure what caused that. But i think we can just un-promisify it and just call it at the render level. I can no longer repro.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leftonread-web ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 1:48AM (UTC)
alexdanilowicz commented 1 year ago

resolves: https://github.com/Left-on-Read/leftonread/issues/463

alexdanilowicz commented 1 year ago

fudge, this doesn't work in released version. totally hangs still.