[Bug] Phone shows light theme on dark mode instead of dark theme on dark mode

LelouchFR / skill-icons

"Fork" of official skill-icons repository. Showcase your skills on your Github readme or resumé with ease ✨

https://go-skill-icons.vercel.app

MIT License

143 stars 23 forks source link

[Bug] Phone shows light theme on dark mode instead of dark theme on dark mode #171

Open 1chooo opened 1 month ago

1chooo commented 1 month ago

Description of the bug

I check the icon on my iPhone all the icon is default in the light theme; however, in my laptop it’s default dark theme. Maybe we need to add configuration to make sure the icons display the dark mode successfully when using the mobile phone.

Steps To Reproduce

Just view in the GitHub Mobile App with the dark theme

Additional Information

No response

Code of Conduct Acknowledgment

[X] I have read and agree to the Code of Conduct.

1chooo commented 1 month ago

I also take the screenshot of your homepage, all the icons change into light mode.

LelouchFR commented 1 month ago

I've been aware of that, but I don't really have an idea of why :/ it may be because of the way that safari is rendering svgs and doesn't really take in count the dark theme and takes everything that is in the css for the theme and parses it as it without media query and shows up the last element changes that are there...