Closed keski closed 3 months ago
What about dropping the
example/
directory [...]
We may want to have an example/
directory to provide a few example queries, but that's a different topic of course. So, yes, for the purpose of this PR, introducing this directory doesn't seem to make much sense.
[...] and replacing the contents of the docker-compose file with:
... volumes: # Use custom config files #- <PATH_TO_CONFIG_FILE>:/usr/local/tomcat/webapps/ROOT/config.properties #- <PATH_TO_ENGINE_CONFIG_FILE>:/usr/local/tomcat/webapps/ROOT/DefaultEngineConf.ttl #- <PATH_TO_FEDERATION_CONFIG_FILE>:/usr/local/tomcat/webapps/ROOT/DefaultFedConf.ttl
Is it possible to replace each of these <PATH_TO_...>
by the respective path to the corresponding file in the resources
subdirectory? (but still have these lines commented out)
If yes, then I would prefer that. Otherwise, I fine with this proposal.
Yes, pointing to the resource sub-directory works fine for now. @hartig
Robin, assuming you are okay with my new change suggestion and commit it, is the PR ready to be merged then?
Fair point. Actually, the file references could be commented out and need not point at any existing files at all. That way it can still be run by default and no extra files need to provided at this point. What about dropping the
example/
directory and replacing the contents of the docker-compose file with: