search

Libnamic / Omeka-S-GoogleAnalytics

Includes simple support for Google Analytics in Omeka S
https://digitalhumanities.libnamic.com
MIT License
3 stars 4 forks source link

preg_match() error in version 1.2.2 when not logged in #4

Closed Steve-A-Orr closed 3 years ago

Steve-A-Orr commented 3 years ago

When using Omeka S version 3.0.2 with Google Analytics version 1.2.2, while NOT logged in I get a "Warning: preg_match(): No ending delimiter '/' found in /home/user/the.site.dir/modules/GoogleAnalytics/Module.php on line 232" error message on the top of pages; while I AM logged in, the error does not show.

Steve-A-Orr commented 3 years ago

Would you prefer I put in a Pull Request with the solution?

Steve-A-Orr commented 3 years ago

We are on Omeka S version 3.1.0 now and still the error is thrown. From the log:

[04-Oct-2021 16:22:19 UTC] PHP Warning: preg_match(): No ending delimiter '/' found in /path/to/site/modules/GoogleAnalytics/Module.php on line 232

What's good is now it seems to only show in the logs and not in the browser--though that could've been because of a change made by another of our Devs.

Steve-A-Orr commented 3 years ago

Okay, I think you fixed the error in the code push that happened six days ago. But, unfortunately, you did not move the module version from 1.2.2 to 1.2.3--consequently, I am guessing that others who are watching this repository, namely the EasyInstall module guy, do not know that you've pushed another update and are still serving the old versions.

I found out by comparing the files given through the EasyInstall module and those on your repository. After manually downloading/uploading your files to my Omeka S site the problem was fixed.

TL;DR - Please bump the module version up, so that others know a change was made six days ago.