Uppercase codepage comparison against lower-case strings must fail

LibreCAD / libdxfrw

Successor of https://sourceforge.net/projects/libdxfrw/, developed for LibreCAD, by LibreCAD Contributors, usable for all

GNU General Public License v2.0

193 stars 72 forks source link

Uppercase codepage comparison against lower-case strings must fail #71

Closed PaulFocus closed 1 year ago

PaulFocus commented 1 year ago

https://github.com/LibreCAD/libdxfrw/blob/34b65b020e636cf5b356b17eb6dd55fe162fcc70/src/intern/drw_textcodec.cpp#L514-L520

cp has been uppercased at the beginning of the method, so comparing it against lower-cased strings will probably not match. Happens in L514 to L520.

lordofbikes commented 1 year ago

many thanks :+1: