search

LibrePhotos / librephotos-docker

You can find here the Dockerfiles for the automated build process of LibrePhotos.
MIT License
157 stars 101 forks source link

Not possible to pass a Redis password as an EVAR #25

Closed GoingOffRoading closed 2 years ago

GoingOffRoading commented 3 years ago

If the user wishes to re-use an existing instance of Redis that has password authentication, that user is unable to do so because an option for a Redis password is not in the:

does it work passing the value manually (Kubernetes example): 

env:
            - name: REDIS_PASSWORD
              value: "$password"

End user should be able to leverage basic password authentication for Redis, which would bring the authentication configuration for Librephoto to parity with the authentication on the backend.

stavros-k commented 2 years ago

Any news on this? That would be great to have

stavros-k commented 2 years ago

If the user wishes to re-use an existing instance of Redis that has password authentication, that user is unable to do so because an option for a Redis password is not in the:

does it work passing the value manually (Kubernetes example):

env:
            - name: REDIS_PASSWORD
              value: "$password"

End user should be able to leverage basic password authentication for Redis, which would bring the authentication configuration for Librephoto to parity with the authentication on the backend.

Looking through the codebase found this: https://github.com/LibrePhotos/librephotos/blob/e2a748b859e80cefc933f4191d60e280b406c483/ownphotos/settings.py#L173-L177

So by using REDIS_PASS you should be able to set redis password ;)

I guess this can be closed, AFTER it's documented ;)

derneuere commented 2 years ago

It's now documented: https://docs.librephotos.com/1/environment_variables/#redis-password