LibrePhotos / librephotos-docker

You can find here the Dockerfiles for the automated build process of LibrePhotos.
MIT License
157 stars 101 forks source link

Use `curl` rather than `git` to download repositories #99

Closed RealOrangeOne closed 1 year ago

RealOrangeOne commented 1 year ago

Curl is much more efficient, and faster

derneuere commented 1 year ago

Thank you for your pull request!

While I do believe that there is a small performance win here, I prefer the readability of just using git.

RealOrangeOne commented 1 year ago

It's not just the performance - the container also ends up smaller as there's less extra metadata to persist. Although yes, the git command is much shorter!