search

LibreSolar / charge-controller-firmware

Firmware for Libre Solar MPPT/PWM charge controllers
https://libre.solar/charge-controller-firmware/
Apache License 2.0
144 stars 71 forks source link

Parse ts nodes #120

Closed Gretel5X closed 3 years ago

Gretel5X commented 3 years ago

To provide additional information to the frontend on the esp32-edge, this PR adds comments on the data-nodes and a grabber, who will parse the comments and outputs a .json file which can be served to the frontend via a file server (how exactly is not yet set up).

For testing run ./grabber.py and inspect the output. There is noexplicit validation of the comments, but json.dump() should fail if comments are not propperly formated as json

Gretel5X commented 3 years ago

Would be nice to have some description about the PR in the below format: What does this PR do? What are the relevant tickets? Where should the reviewer start? How should this be manually tested? Any background context you want to provide? Screenshots (if appropriate)

Hey @azeemshatp, you are right, most of the communication for this feature was on telegram with @martinjaeger , I will update the description

Gretel5X commented 3 years ago

In fact the first commit should not be in there, I will have to fix that. Converted to draft

Gretel5X commented 3 years ago

Will close this PR and open a new one with clean history based on current develop branch