search

LibreSolar / charge-controller-firmware

Firmware for Libre Solar MPPT/PWM charge controllers
https://libre.solar/charge-controller-firmware/
Apache License 2.0
144 stars 71 forks source link

Thingset serial support using zephyr framework #85

Closed azeemshatp closed 4 years ago

azeemshatp commented 4 years ago

What does this PR do? Thingset serial support using Zephyr framework.

What are the relevant tickets? NA

Where should the reviewer start? The file serial.cpp

How should this be manually tested? Connect serial port to the PC terminal. Send the command !info to receive data from the device.

Any background context you want to provide? At the moment this is implemented without using callbacks for reading the console inputs.

Screenshots (if appropriate)

martinjaeger commented 4 years ago

The unit-tests fail in CI. Please check.

martinjaeger commented 4 years ago

You might need to rebase master, as there is a merge conflict with main_zephyr.cpp, which has changed in the last days.

And as a general comment: Please use git commit --amend and force-push for tiny fixes like the platformio.ini change, so that we don't have too many commits for small changes.

In the main Zephyr project, changes after review are added to the previous commits, see workflow description. So there is no "Fixes after review" commit in the git history afterwards where the content is not clear from the commit message. I think this approach makes sense. But for this PR it's not necessary, as I can just squash merge it at the end (so we get only one commit in master).