Not working anymore - Githubissues

LifeOnScreen / nova-google2fa

This package provides Google2FA support to Laravel Nova.

23 stars 56 forks source link

Not working anymore #19

Open ben182 opened 5 years ago

ben182 commented 5 years ago

The QR Code generation is not working anymore since the Google API for QR generator is turned off. This is explained here: https://github.com/antonioribeiro/google2fa. The QR Codes have to be created in other ways now: https://github.com/antonioribeiro/google2fa#generating-qrcodes

GarethSomers commented 4 years ago

@lenrsmith might have resolved this in this commit https://github.com/lenrsmith/nova-google2fa/commit/6919f6672c71c30b686234e23a1023d82be5a1c4

I'm going to try his fork

lenrsmith commented 4 years ago

@GarethSomers Let me know if you run into any issues. I plan to clean up my fork and submit a PR to the main repo.

rickgoemans commented 4 years ago

@lenrsmith You version passes the login middleware and shows me the security codes. But when I click continue I get the no hint path defined for nova error. Any suggestion on how to solve?

It's related to @include('nova::partials.logo') in resources/views/register.blade.php (and probably the other files will result in an error later on). I've had a fork of my own where I just disabled these parts of the code but I wonder how you guys are going it...

GarethSomers commented 4 years ago

Hi @rickgoemans I've parked the bus on this right now. One problem I ran into was it only allowed the user to be logged in at one location (and kicked them both out if someone tried to login). Not sure if that's standard for 2 factor but I disabled it (temporarily) as a result.