search

Lightning-AI / lightning-Graphcore

Apache License 2.0
7 stars 4 forks source link

fix missing extras & extend package check #49

Closed Borda closed 1 year ago

Borda commented 1 year ago
Before submitting - [x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [x] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [x] Did you write any new necessary tests?

What does this PR do?

Follow-up based on https://github.com/Lightning-AI/utilities/pull/184

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Borda commented 1 year ago

the problem seems with unrecognized extras: WARNING: lightning-graphcore 0.1.0 does not provide the extra 'pytorch-lightning'