Open Daniel-K-Ivanov opened 5 years ago
Generally speaking utils global variable is not okay, because every project has its own utils file.
utils
To add on top of that - it is somewhat confusing. I personally did not expected to have global utils variable.
Suggestion: replace the current utils global variable with etherlime.utils global variable.
etherlime.utils
Example usage: Before:
utils.hasEvent(transactionReceipt, LimeFactory, expectedEvent);
Suggestion:
etherlime.utils.hasEvent(transactionReceipt, LimeFactory, expectedEvent);
Generally speaking
utils
global variable is not okay, because every project has its ownutils
file.To add on top of that - it is somewhat confusing. I personally did not expected to have global
utils
variable.Suggestion: replace the current
utils
global variable withetherlime.utils
global variable.Example usage: Before:
Suggestion: