search

LimeChain / etherlime

Dapp Development framework based on ethers.js
MIT License
185 stars 41 forks source link

Cannot compile on select version of solc #328

Open elenadimitrova opened 4 years ago

elenadimitrova commented 4 years ago

Error thrown when not using a locally installed version of solc 

> etherlime compile --solcVersion 0.5.4

Sun, 05 Jul 2020 08:49:31 GMT unhandledRejection: Failed to complete request to: http://etherlime.limechain.tech/solc/bin/list.json.

Also this fails confirming it's a problem getting a list of supported solc versions to compare against

npx etherlime compile --list releases --all
Error: Failed to complete request to: http://etherlime.limechain.tech/solc/bin/list.json.

Error: getaddrinfo ENOTFOUND etherlime.limechain.tech etherlime.limechain.tech:80
    at CompilerSupplier.errors (/node_modules/etherlime-argent/cli-commands/compiler/etherlime-compile/compilerSupplier.js:386:16)
    at axiosInstance.get.then.catch.err (/node_modules/etherlime-argent/cli-commands/compiler/etherlime-compile/compilerSupplier.js:161:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Sample failing build https://circleci.com/gh/argentlabs/argent-contracts/1089

ochikov commented 4 years ago

I just tried to compile a simple contract with 0.5.4 version and it seems to work. Can you confirm it ?

elenadimitrova commented 4 years ago

It was fixed meanwhile yes, but for all of 3 days we couldn't compile. You can see the sample failing build in CI. The reliance on a limechain service for compilation is really a single point fo failure that's not acceptable. So this dependency should be removed to prevent this from happening again.

edmundedgar commented 4 years ago

Same problem here. There's some kind of DoS protection on the hosted site that seems to be misfiring. Hitting one of the failing URLs directly in a web browser from my Japanese connection produces:

etherlime.limechain.tech is protected! We have noticed an unusual activity from your IP: 143.189.165.88 and your access to the site is blocked. You can contact our support for more information. If doing so please provide the following ID: 403.

Hitting the thing from a cloud host doesn't trigger the bug.

PS. It also feels bad to be downloading this software from a plain http address, maybe consider just hosting it off github?