Revert BC breaking changes for PHP 5.5+ in ReactRenderer v4 - Githubissues

Limenius / ReactRenderer

Client and Server-side React rendering from PHP

MIT License

237 stars 37 forks source link

Revert BC breaking changes for PHP 5.5+ in ReactRenderer v4 #41

Open ryanolee opened 4 years ago

ryanolee commented 4 years ago

Hi @nacmartin and the team at Limenius, Thanks for setting all up. Much appreciated.

As outlined in #39 There are some breaking BC changes with php v5 in V4+ of the app. This PR aims to add that compatibility back into the mainline for the v4 of this package.

Note that this needs merging into a new branch split for v4 dev from https://github.com/Limenius/ReactRenderer/commit/83383e00c512aa1cedb9766ed8f01a0e1b14949f and not master. Would be happy to rebase if you create the new branch is open on the main repo. (Not v5 due to issues outlined in #40 which I am not sure there is much we can do about)

Thanks!