Fix optional parameters

Limenius / ReactRenderer

Client and Server-side React rendering from PHP

MIT License

237 stars 37 forks source link

Fix optional parameters #48

Closed nacmartin closed 3 years ago

nacmartin commented 3 years ago

As pointed in https://github.com/Limenius/ReactRenderer/pull/36 some optional parameters where declared before non optional parameters, which is wrong. I think this PR is safe and won't break anyone's code, but it is still a minor BC break.

rasmustnilsson commented 3 years ago

Hi, do you mind creating a new version/tag which includes this fix?

VincentLanglet commented 3 years ago

HI @nacmartin, do you mind creating a new release with this ? :)

nacmartin commented 2 years ago

Released