Linaro / OpenCSD

CoreSight trace stream decoder developed openly
https://github.com/Linaro/opencsd/wiki
Other
143 stars 54 forks source link

Add #include <cstdlib> for strtol and getenv. #64

Open alexfh opened 2 weeks ago

alexfh commented 2 weeks ago

Recent changes to LLVM libc++ discovered missing #includes. This code is using strtol and getenv, so it needs to include <cstdlib> or <stdlib.h> - whichever is more consistent with the the project coding style.

alexfh commented 1 week ago

@mikel-armbb would you be the right reviewer for this?

mikel-armbb commented 1 week ago

Hi,

Thanks for this.

I'll add this in the next opencsd patch release.

Mike

mikel-armbb commented 1 week ago

@alexfh : do you have specific version where this is failiing. We are currently using Apple Clang 14.0.3 without issues.

Thanks

Mike