search

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
62 stars 70 forks source link

50-adbd-cmdline.conf: Change /var to /etc in ConditionPathExists #623

Open quic-raghuvar opened 3 weeks ago

quic-raghuvar commented 3 weeks ago

If android-tools-adbd.service service needs to be up upon boot, then the path assigned to ConditionPathExists must be present at boot time. This means that the path set to ConditionPathExists must be created at build time itself. /etc is a better place to keep files and directories that are created at build time rather than /var. /var is expected to house files that are created at run time.

Hence, change ConditionPathExists=|/var/usb-debugging-enabled to ConditionPathExists=|/etc/usb-debugging-enabled

lumag commented 3 weeks ago

Meta-oe still uses /var for the kirkstone branch. Please get the corresponding patch backported first.

lumag commented 3 weeks ago

BTW: with your meta-oe patch you have created internal inconsistency between selinux-enabled and -disabled configurations. See https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools/android-tools-adbd.service

Please send a patch fixing this inconsistency ASAP, add me to the Reported-by tag

lumag commented 2 weeks ago

@quic-raghuvar I've pointed out at meta-openembedded, but these items apply here too: