LinbuduLab / esbuild-plugins

ESBuild plugins by @LinbuduLab
MIT License
113 stars 18 forks source link

fix: cannot read slice of undefined Error #108

Open andrew1931 opened 4 months ago

andrew1931 commented 4 months ago

when I have config like this:

assets: {
    from: [
        'node_modules/[some-library-1]/filename',
        'node_modules/[some-library-2]/filename',
    ],
    to: ['dist']
},

I have an error "Cannot read slice of undefined". With this "continue" statement from my commit all the files are being copied without any errors.

PS: I don't see why in esbuild-plugin-copy.ts file you call "copyOperationHandler" for every item in "to" array in a loop for every item in "from" array and then inside "copyOperationHandler" function you run a loop for "from" paths again. There won't be this error without this inner loop inside "copyOperationHandler". But I believe there is a reason for this logic:) cheers

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 124ed856448d23dbbb63276f562150a1f5006b3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR