search

LinbuduLab / esbuild-plugins

ESBuild plugins by @LinbuduLab
MIT License
113 stars 18 forks source link

Supress clean files output #76

Closed jasonwilliams closed 2 years ago

jasonwilliams commented 2 years ago

Hey great plugin!

When the esbuild-clean-plugin cleans its files it prints out a list of all the files cleaned. I don't really need this information it just spams the logs. Can we have an option to supress it?

I didn't see anything obvious in https://nx-plugins.netlify.app/derived/esbuild.html#clean

I feel like this should be off by default then switched on by a verbose mode or something? Just a suggestion

linbudu599 commented 2 years ago

Sure, I created this plugin in a great hurry, thank you for your feedback, I will make adjustments immediately.

linbudu599 commented 2 years ago

This is supported in esbuild-plugin-clean@0.9.0, as now this plugin uses silent mode by default(as it should be). You can also refer to the docs: https://nx-plugins.netlify.app/derived/esbuild.html#configuration-2

jasonwilliams commented 2 years ago

Thank you for the speedy reply! I will try it out early next week and report back.

jasonwilliams commented 2 years ago

Hey I didn't want to make a new issue for this but your copy plugin is also verbose by default. Are you able to switch that to be false by default?

linbudu599 commented 2 years ago

Hey I didn't want to make a new issue for this but your copy plugin is also verbose by default. Are you able to switch that to be false by default?

Sure, I used to set verbose option to be true by default because this plugin was not stable yet, clear logs help solve problems better, and now I think it can indeed be turned off.

Fixed in 1.3.0.