search

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.
http://layoutkit.org
Apache License 2.0
3.16k stars 267 forks source link

Create list with limitations/constraints of LabelLayout #123

Open plamenterziev opened 7 years ago

plamenterziev commented 7 years ago

LabeLayout relies on boundingRect method which does not work in all cases and I think that it would be great from documentation perspective if have a list of all limitations/constraints found so far.

I've spent few hours finding out why boundingRect does not return valid size and it turned out that it does not work if the NSAttributedString has NSParagraphStyle with line break set to NSLineBreakByTruncatingTail and the number of lines is 0

So here is one issue :)

jingwei-huang1 commented 7 years ago

@plamenterziev Thanks for your feedbacks. For your NSAttributedString, did you make Text and pass to LabelLayout initializer or update attributed text in config?

jingwei-huang1 commented 7 years ago

@plamenterziev Could you please also provide the information how you set the NSAttributedString to LayoutLabel?

plamenterziev commented 7 years ago

@jingwei-huang1 - I am creating the Text and pass to the LabelLayout initializer (have no config)

staguer commented 7 years ago

@plamenterziev We can definitely mention this issue in the layout's documentation comments. Do you know of a way to come up with an exhaustive list of such issues?

In the longer term, I'm considering implementing a Layout that would render text to a layer at measurement time, avoiding any boundingRect / UILabel disagreements.

jingwei-huang1 commented 7 years ago

@plamenterziev I tried to reproduce the same thing, but I couldn't found the issue. Could you please also provide the code how you set it up?