search

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.
http://layoutkit.org
Apache License 2.0
3.16k stars 267 forks source link

Open ReloadableViewLayoutAdapter UIKit implementations #129

Closed Rep2 closed 7 years ago

Rep2 commented 7 years ago

Making ReloadableViewLayoutAdapter UIKit implementations (UITableViewDelegate, UITableViewDataSource, UICollectionViewDelegateFlowLayout, UICollectionViewDataSource) open in order to allow for easy customisation of default behaviour.

This allows for potentially breaking overrides of given methods. Unfortunately, Swift currently does not have something like __attribute((objc_requires_super)). That being said, I think this change is still beneficial.

Fixes #128

codecov-io commented 7 years ago

Codecov Report

Merging #129 into master will decrease coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   92.38%   92.26%   -0.13%     
==========================================
  Files          58       58              
  Lines        3311     3311              
==========================================
- Hits         3059     3055       -4     
- Misses        252      256       +4
Impacted Files Coverage Δ
...iews/ReloadableViewLayoutAdapter+UITableView.swift 86.66% <100%> (ø) :arrow_up:
...ReloadableViewLayoutAdapter+UICollectionView.swift 89.28% <100%> (ø) :arrow_up:
LayoutKit/Views/ReloadableViewLayoutAdapter.swift 81.05% <0%> (-4.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2df3a70...c92dbca. Read the comment docs.