Fix StackLayout fillEqualSpacing distribution with spacing

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.

http://layoutkit.org

Apache License 2.0

3.16k stars 267 forks source link

Fix StackLayout fillEqualSpacing distribution with spacing #160

Closed domasn closed 7 years ago

domasn commented 7 years ago

Updates StackLayout.distributionConfig and calculates the axisSpacing taking into account the spaces that were already added during the measurement phase. Actual excessAxisLength for .fillEqualSpacing is increased by numberOfSpaces * spacing so it can be redistrubuted.

See issue https://github.com/linkedin/LayoutKit/issues/159

nicksnyder commented 7 years ago

Thanks for the PR! I haven't looked at the issue yet, but this PR will unit need tests before it is mergeable.

staguer commented 7 years ago

Thank you for adding unit tests.

I'm curious, why doesn't this PR have the automatic CI verification like the other PRs do?

domasn commented 7 years ago

@staguer Great question, I don't really know though. As you can see this pull is from a fix branch on my fork, but that shouldn't really matter to CI.

nicksnyder commented 7 years ago

It looks like Travis thinks it has detected abuse:

I contacted Travis support to see what is going on.

nicksnyder commented 7 years ago

@domasn Travis support says the abuse flag has been removed. Please push an empty commit or rebase against master to trigger a new build.