search

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.
http://layoutkit.org
Apache License 2.0
3.16k stars 267 forks source link

Add animationType to BatchUpdates #177

Open fmirault opened 6 years ago

fmirault commented 6 years ago

and use it for insertRows / deleteRows / reloadRows / insertSections / deleteSections / reloadSections methods.

Possible addition to #124 for animations.

fmirault commented 6 years ago

Hi !

Still no news since january 4th for my PR, maybe I missed something or I have to ask for a review ?

Regards,

staguer commented 6 years ago

Apologies for the delay, @fmirault .

I added a comment. This adapter is used for both table views and collection views, so it'd be odd to have a property that has no effect in some cases. Would it be possible to make it (or something like it) work in both cases?

fmirault commented 6 years ago

Collection View isn't working like Table View, so I don't really see how I can achieve the same effect on it (it's an UIKit limitation in my opinion).