Feature - Swift4.1 - Githubissues

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.

http://layoutkit.org

Apache License 2.0

3.16k stars 267 forks source link

Feature - Swift4.1 #197

Closed ppeelen closed 4 years ago

ppeelen commented 6 years ago

This PR will add support for Swift 4.1 and XCode 9.3

• Swift 4.1 • XCode 9.3 Enable: -> Implicit retain of self within blocks -> Overriding deprecated obj-c methods -> Whole module optimization • Remove weak protocol properties • Changes flapMap to compactMap

staguer commented 6 years ago

@ppeelen Thank you for making these changes. Do you know what's causing the travis CI build to fail?

ppeelen commented 6 years ago

@staguer Unfortunately I have not had the time to find the underlying reason why Travis is failing. We are running CircleCI for our projects, including a fork of LayoutKit and have the full project successfully running on our end.

My initial thought is that the swift version change has not gone through properly on all targets and/or Travis. However, it does build/test/run locally.

I will get back to you as soon as I have had a possibility to checkout the Travis problem.