LinkedInAttic / hopscotch

A framework to make it easy for developers to add product tours to their pages.
Apache License 2.0
4.19k stars 661 forks source link

Feature: To show step in center or bottom right on target not found in step options #84

Open k10world opened 10 years ago

k10world commented 10 years ago

Although target not found should be avoided at all costs, but there must be a fail-safe. A tour discontinued on the next button is a bad user experience. Instead at least showing the bubble in center or bottom right and letting the user continue to next step, is not as bad an experience.

Bootstrap tour provides this option. It is called the orphan step. http://bootstraptour.com/api/

Allow to show the step regardless whether its element is not set, is not present in the page or is hidden. The step is fixed positioned in the middle of the page.

Any thoughts?

k10world commented 10 years ago

I can work towards this, if it sounds like a good idea

timlindvall commented 10 years ago

An interesting idea. I don't think we should have this on by default (a tour might intend to skip over in the event the element isn't found), but I could see this as a useful tour and/or step option. Generally, I'm hesitant to vote for enhancements due to the potential risk of config and feature bloat, but I'm not sure if there's a nice way to duplicate this functionality with callbacks, at least with what we have currently.

Anyone else have any additional thoughts on the suggestion?

kate2753 commented 10 years ago

The idea of orphan step sounds interesting. It could be useful feature for showing information about the page instead of specific element.

This can probably be done with callbacks, but I feel that there should be an easy way to do this. Hopscotch should support this out of the box.

I do not mind having an option skipStepWithoutTarget set to true by default (for backward compatibility). It could be both tour and step level config.

When step does not have a target, it should probably centered vertically and horizontally on the page.

Any other things we need to consider?

k10world commented 10 years ago

@zimmi88 I agree with @kate2753 - should I'll work on this next. Thanks