LinuxBozo / jsonresume-theme-kendall

A theme for jsonresume
MIT License
54 stars 78 forks source link

Profile Icons Disappearing #9

Closed zainfathoni closed 8 years ago

zainfathoni commented 8 years ago

I tried to generate the JSON Resume file using the Resume Editor and it works well on the preview page. image

But after downloading the JSON Resume file and building an HTML file based on the JSON file, the fa fa-twitter-square class disappeared which cause the icons missing. image image

I already made sure the JSON file is exactly same with the one in the Resume Editor. I also tried to use both installation (from npm and directly from github), but the results are the same. I even tried to modify the source code, but I am still a newbie in Node.js, so I didn't know what I did for sure.

If you manage to fix it later, please let me know where the problem source is exactly. Thank you very much. :smile:

xuyizhe commented 8 years ago

I met the same bug when I use HackMyResume to build. The problem may come from it if you also use. resume-cli can work well.

anthu commented 8 years ago

I'm using FluentCV and facing the same issue. I investigated that the network name doesn't match in the switch/case statement.

For example the value "github" in my json is encoded (after using charCodeAt()) "NaN 64 64 64 126 103 105 116 104 117 98 126 64 64 64 64" but should be "103 105 116 104 117 98". These extra chars seems to be non-printable but trim() didn't help.

For my case I found a workaround: see anthu@216fbb5

LinuxBozo commented 8 years ago

@anthu want to go ahead and submit a pull request for that?

anthu commented 8 years ago

I've found the main reason for the failure with FluentCv/HackMyResume. Both tools are hardening the strings against interpretation as Markdown (with '@@@@~' + txt + '~@@@@' ). So the hardened strings of course don't match to plain strings.

I will open a Merge Request to FluentCV- hope to get the reason.

So far - here is my fix for FluentCV: anthu/FluentCV@5f324fd

LinuxBozo commented 8 years ago

In that case, closing.. thanks for the investigation work!