LinuxForHealth / patient-browser

Other
3 stars 7 forks source link

js file not found #33

Closed Cyndi-Tsui closed 2 years ago

Cyndi-Tsui commented 2 years ago

When patient-browser started run, console.log show some js files can not be found:

[12/20/21 6:23:35:867 UTC] 00000037 com.ibm.ws.webcontainer.extension                            W SRVE0190E: File not found: /js/index.js
[12/20/21 6:23:35:875 UTC] 00000024 com.ibm.ws.webcontainer.extension                            W SRVE0190E: File not found: /js/commons.js
[12/20/21 6:23:35:946 UTC] 00000031 com.ibm.ws.webcontainer.extension                            W SRVE0190E: File not found: /js/commons.js
[12/20/21 6:23:35:978 UTC] 0000002d com.ibm.ws.webcontainer.extension                            W SRVE0190E: File not found: /js/index.js

I checked the code history, js folder was removed in this PR: https://github.com/Alvearie/patient-browser/pull/32 But there is still some reference here: https://github.com/Alvearie/patient-browser/blob/master/build/index.html#L15-L16

@mcbride-p Could u help check this issue?

mcbride-p commented 2 years ago

Hi @Cyndi-Tsui - Yes I actually removed build/js folder in terms of what's checked in previously as that can be regenerated/built by doing an 'npm i' (as you've probably found out already yourself anyway. I've updated relevant readme -> https://github.com/Alvearie/patient-browser/blob/master/security/README.md to include this step before generating patient-browser.war file.