Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.66k stars 237 forks source link

Restore (fixed) make shim #766

Closed maxim-belkin closed 6 years ago

maxim-belkin commented 6 years ago

restore make shim. new and improved

Tested by installing tig from source: https://gist.github.com/b12e9ecfe02cb065806be72bfeab0460

codecov-io commented 6 years ago

Codecov Report

Merging #766 into master will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   68.66%   68.65%   -0.02%     
==========================================
  Files         393      393              
  Lines       21177    21177              
==========================================
- Hits        14542    14539       -3     
- Misses       6635     6638       +3
Impacted Files Coverage Δ
utils/analytics.rb 82.05% <0%> (-7.7%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 468d869...f0ac269. Read the comment docs.

jonchang commented 6 years ago

Confirmed that this seems to fix things, at least for tig.

jonchang commented 6 years ago

Thanks @maxim-belkin and @xu-cheng!!

iMichka commented 6 years ago

Thanks! I will build some more bottles with this and keep you updated.