Linuxbrew / brew

:beer::penguin: The Homebrew package manager for Linux
https://linuxbrew.sh
BSD 2-Clause "Simplified" License
2.66k stars 237 forks source link

.gz files are not extracted correctly #767

Closed randy3k closed 6 years ago

randy3k commented 6 years ago

To help us debug your issue please explain:

install rstudio-server formula

The .gz resource file is not extracted correctly

see https://circleci.com/gh/randy3k/homebrew-r/418

The formula used to work, so the error is caused by a recent commit.

formula installed correctly

just tap randy3k/homebrew-r and run brew install rstudio-server

jonchang commented 6 years ago

bisect on linuxbrew says:

commit 5b3bbb76c9d224c08ae498677868b69aab71ff7c
Author: Markus Reiter <me@reitermark.us>
Date:   Sun Jul 1 23:35:29 2018 +0200

    Separate staging from download.

:040000 040000 6d5d52263444dbca74d030b9714bd87afff1d386 183e6d00db7777ddcadf1ce9017e320bed2d45c2 M  Library
jonchang commented 6 years ago

It works on macOS so there must have been a fix applied upstream. This will be addressed once 1.7.2 from upstream is merged and tagged.

randy3k commented 6 years ago

It has platform dependent resource files. The macos resource is .zip though.

jonchang commented 6 years ago

I tested a reduced formula using the .gz file.

randy3k commented 6 years ago

Great.

sjackman commented 6 years ago

We've recently merged Homebrew/brew into Linuxbrew/brew master. Can you test whether this works now?

iMichka commented 6 years ago

There is still an issue open regarding an equivalent problem for weird tgz files upstream: https://github.com/Homebrew/brew/issues/4648 Just that you know that not everything may be working out of the box.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

sjackman commented 6 years ago

This issue will be fixed by PR https://github.com/Homebrew/brew/pull/4662, once it's merged into Homebrew/brew and Linuxbrew/brew.

sjackman commented 6 years ago

Linuxbrew 1.7.3 includes this fix.