configure-shell: remove HOMEBREW paths before adding

maxim-belkin commented 6 years ago

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

User can add Homebrew/Linuxbrew PATHs in many ways. This is a proposal to remove Homebrew/Linuxbrew paths before adding them.

maxim-belkin commented 6 years ago

CC @jamescostian

sjackman commented 6 years ago

Removing duplicate elements from PATH has no measurable benefit and adds complexity, so I'd rather not merge this PR. Thanks all the same, Maxim. In addition, plan to remove brew configure-shell in favour of brew shellenv which is now available in Linuxbrew/brew.

maxim-belkin commented 6 years ago

ah, I didn't see that shellenv. OK then

Linuxbrew / brew

configure-shell: remove HOMEBREW paths before adding #845